Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BYOR: Add vip app deploy #1560

Merged
merged 13 commits into from
Dec 18, 2023
Merged

BYOR: Add vip app deploy #1560

merged 13 commits into from
Dec 18, 2023

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented Nov 17, 2023 •
edited
Loading

Description

Adding vip app deploy to VIP-CLI

Steps to Test

  1. In src/bin/vip-app-deploy.js, need to comment out for now:
await track( 'deploy_app_command_execute' );
		await track( 'deploy_app_command_execute' );
		await gates( app, env, fileMeta );
  1. node ./dist/bin/vip-app-deploy.js -a 5190 -e production ~/Desktop/skeleton.zip

@rebeccahum rebeccahum force-pushed the add/byor branch 3 times, most recently from 2d71c6c to 70aa250 Compare November 18, 2023 00:06
@rebeccahum rebeccahum force-pushed the add/byor branch 7 times, most recently from 76ad970 to d9f0fc9 Compare December 6, 2023 00:49
@rebeccahum rebeccahum marked this pull request as ready for review December 6, 2023 00:50
@rebeccahum rebeccahum force-pushed the add/byor branch 18 times, most recently from 4bf4200 to fd4106e Compare December 11, 2023 17:50
@mjangda
Copy link
Member

mjangda commented Dec 11, 2023 •
edited
Loading

@Crixu How well does vip deploy app fit in with the new IA for VIP-CLI? Should this be vip app deploy instead?

@Crixu
Copy link

Crixu commented Dec 12, 2023

I agree that vip app deploy is a better choice and makes sure we're moving in the right direction for the future

@rebeccahum rebeccahum changed the title BYOR: Add vip deploy app BYOR: Add vip app deploy Dec 12, 2023
@rebeccahum rebeccahum force-pushed the add/byor branch 2 times, most recently from b8671ca to 704fd00 Compare December 12, 2023 14:12
@rebeccahum
Copy link
Contributor Author

I've changed it to app deploy -- I like having the idea of an app rollback as well.

@rebeccahum rebeccahum force-pushed the add/byor branch 6 times, most recently from 1bf66cc to c0bcda3 Compare December 15, 2023 22:14
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot
3.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@rebeccahum rebeccahum merged commit 5d862dd into trunk Dec 18, 2023
13 of 14 checks passed
@rebeccahum rebeccahum deleted the add/byor branch December 18, 2023 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WPprodigy WPprodigy WPprodigy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rebeccahum @mjangda @Crixu @WPprodigy